Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Compiled Autograd tutorial with images #3108

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Update Compiled Autograd tutorial with images #3108

merged 3 commits into from
Oct 23, 2024
+10 −91

Conversation

xmfan
Copy link
Member

@xmfan xmfan commented Oct 22, 2024 •
edited
Loading

Fixes #3107

Description

I'm replacing the long string errors with annotated images, with some minor additions:
e.g.

Before
image

After
image

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3108

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 1d69204 with merge base 0c5e2c6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@xmfan xmfan marked this pull request as ready for review October 22, 2024 21:50
albanD
albanD approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is amazing! Thanks for taking the time to do these improvements!

svekars
svekars reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise looks good - let's wait for the preview to check.

intermediate_source/compiled_autograd_tutorial.rst Outdated Show resolved Hide resolved
intermediate_source/compiled_autograd_tutorial.rst Outdated Show resolved Hide resolved
@xmfan
Copy link
Member Author

xmfan commented Oct 22, 2024 •
edited
Loading

Seems to have rendered correctly: https://docs-preview.pytorch.org/pytorch/tutorials/3108/intermediate/compiled_autograd_tutorial.html

I'll apply the suggestions

@xmfan @svekars
Apply suggestions from code review
2e63a13 
Co-authored-by: Svetlana Karslioglu <[email protected]>
@svekars svekars merged commit 90525b7 into pytorch:main Oct 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svekars svekars svekars approved these changes

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiled autograd tutorial review feedback
4 participants
@xmfan @svekars @albanD @facebook-github-bot